Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed alpine image #1279

Merged
merged 2 commits into from
Jan 17, 2024
Merged

removed alpine image #1279

merged 2 commits into from
Jan 17, 2024

Conversation

Yanni8
Copy link
Contributor

@Yanni8 Yanni8 commented Jan 16, 2024

Autogen currently uses the alpine Python Docker image to execute code.

This can result in unexpected behaviors:
https://pythonspeed.com/articles/alpine-docker-python/

I think that it would make sense to replace alpine with slim

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adbfb20) 32.08% compared to head (b532019) 41.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   32.08%   41.96%   +9.87%     
==========================================
  Files          32       32              
  Lines        4394     4394              
  Branches     1025     1080      +55     
==========================================
+ Hits         1410     1844     +434     
+ Misses       2867     2401     -466     
- Partials      117      149      +32     
Flag Coverage Δ
unittests 41.89% <ø> (+9.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qingyun-wu
Copy link
Contributor

qingyun-wu commented Jan 16, 2024

@sonichi any specific reason why we choose to put alpine at the very beginning? If not, I believe this suggested change is reasonable.

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This solves a long-standing problem I had. I appreciate your help.

@sonichi sonichi added this pull request to the merge queue Jan 17, 2024
Merged via the queue into microsoft:main with commit 46e76d2 Jan 17, 2024
79 of 84 checks passed
joshkyh pushed a commit that referenced this pull request Jan 17, 2024
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
@ekzhu ekzhu added code-execution execute generated code docker Issues relating to Docker labels Jan 17, 2024
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-execution execute generated code docker Issues relating to Docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants